-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Additional Sample Scenes and Fixed Tap-to-Place Slover #11522
Merged
AMollis
merged 9 commits into
microsoft:mrtk3
from
marlenaklein-msft:ValidateSampleScenes2
Apr 27, 2023
Merged
Added Additional Sample Scenes and Fixed Tap-to-Place Slover #11522
AMollis
merged 9 commits into
microsoft:mrtk3
from
marlenaklein-msft:ValidateSampleScenes2
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtk3 example scenes migration
marlenaklein-msft
requested review from
AMollis,
shaynie and
srinjoym
as code owners
April 27, 2023 21:27
AMollis
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add these scenes to the build script Scott just updated.
AMollis
approved these changes
Apr 27, 2023
AMollis
changed the title
Added Additional Sample Scenes
Added Additional Sample Scenes and Fixed Tap-to-Place Slover
Apr 28, 2023
drusk-unity
pushed a commit
to drusk-unity/MixedRealityToolkit-Unity
that referenced
this pull request
Jun 26, 2023
* Migrating important example scenes from MRTK2 * Update sample scenes * Add HandMenu * Fix TapToPlace Solver * Fix comments * Add scenes to build app --------- Co-authored-by: Yoon Park <cre8ive.park@gmail.com> Co-authored-by: RogPodge <39840334+RogPodge@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adding some example scenes for the high-priority features frequently used by customers from v2:
TapToPlace Example: Known issue - only magnetic behavior works when 'auto start' is checked. Select (pickup/place)behavior is not working. Need engineering investigation on input/interactor.
Clipping Example
Outline Example
Solver Example (Follow / RadialView / InBetween)
Directional Indicator Example
Changes