Add already tracked controllers in Awake #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -194,11 +205,6 @@ private void Application_onBeforeRender() | |||
| } | |||
|
|
|||
| #if UNITY_WSA && UNITY_2017_2_OR_NEWER | |||
| private void InteractionManager_InteractionSourceUpdated(InteractionSourceUpdatedEventArgs obj) | |||
| { | |||
| StartTrackingController(obj.state.source); | |||
There was a problem hiding this comment.
Do we really want to remove this?
What happens if we lose our controllers and then get them back?
There was a problem hiding this comment.
Disregard my comment. I read your issue better. Looks like a great change!
There was a problem hiding this comment.
InteractionSourceLost and InteractionSourceDetected handle those cases correctly.
StephenHodgson
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1194