Added Windows API Contract Checker #1308
Conversation
Moved InteractionSourceExtentions back into Utilities/Extensions Updated Build Window to only support 16299 SDK build target
| @@ -89,19 +99,22 @@ public static void StopHaptics(this InteractionSource interactionSource) | |||
| public static IAsyncOperation<IRandomAccessStreamWithContentType> TryGetRenderableModelAsync(this InteractionSource interactionSource) | |||
| { | |||
| IAsyncOperation<IRandomAccessStreamWithContentType> returnValue = null; | |||
|
|
|||
| UnityEngine.WSA.Application.InvokeOnUIThread(() => | |||
|
|
|||
There was a problem hiding this comment.
What's wrong with the whitespace here?
There was a problem hiding this comment.
nvm I see it, thanks!
| [SerializeField] | ||
| private Text text; | ||
|
|
||
| public void CheckV5Api() |
There was a problem hiding this comment.
Pressing the buttons with a motion controller doesn't seem to call this code (voice "select" works). Is that something that'll be fixed with your uGUI fixes?
There was a problem hiding this comment.
That is correct. Will be fixed by the uGUI raycast PR
| - component: {fileID: 1598773014} | ||
| - component: {fileID: 1598773019} | ||
| m_Layer: 5 | ||
| m_Name: Canvas |
There was a problem hiding this comment.
The buttons are in the floor on an immersive HMD, so we should probably put a SceneContentAdjuster on them.
Also, I tried that, and the SceneContentAdjuster only seems to work in Play mode. When I built and deployed to an immersive HMD, the buttons were still in the floor. Was that tested to work when deployed?
There was a problem hiding this comment.
SceneContentAdjuster also overwrites the X and Z values, which doesn't seem ideal.
There was a problem hiding this comment.
I'll double check this in a different PR. Open an issue for me please?
Should be working when deployed (Worked for me in MRTP3, but they did change the way that stuff works so idk)
There was a problem hiding this comment.
@keveleigh I'll address this in #1309 Removed OptimizeSceneForDeviceType
Fixes #1289
Fixes #1325