-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Portal Updates #1471
Build Portal Updates #1471
Conversation
Added GetMachineName portal API. Added Float and Int editor pref utilities.
Clean up and formatting.
Cleanup and Perf optimizations
Merge branch 'MRTK-Master' into MRTK-BuildPortal2
Found 1 issue. Although in fairness, this should be available and point to https://localhost:50443 Thoughts @StephenHodgson ? |
Well, if you select local machine, then the active IP is the local one. But I should look at cleaning that up if the address isn't properly filled out. Under the hood if the address is invalid, it doesn't do anything anyway. Does the 50443 port number have any special significance? |
50443 is the default port assigned for Immersive Headsets I guess. Unless the port is totally random, in which case you'll need to make it configurable on the screen. Best to get a few to test and report their ports |
Why would you need to add an immersive headset to the machine options? |
Because the Device Portal is a general device portal and also works for immersive headsets :D |
I'm confused. Why do you need the device portal for a local PC machine though? |
The Build window already handles everything you need to do for the local machine. No device portal required. |
Ok, fair enough. Only thought Immersive / Local machine users might find easy access to the device portal useful as well. If we're not supporting that, then just ensure the button is only enabled for IP / HL targets :D |
I believe it should get disabled if there isn't a HoloLens detected. Let me know if this isn't the case. |
@DDReaper added you as moderator. Please accept invite. |
Overview
Changes