Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Portal Updates #1471

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Dec 2, 2017

Overview

image
image
image

Changes

Stephen Hodgson and others added 24 commits September 17, 2017 03:36
Added GetMachineName portal API.
Added Float and Int editor pref utilities.
Cleanup and Perf optimizations
@StephenHodgson StephenHodgson changed the base branch from master to Dev_Working_Branch December 2, 2017 22:00
NeerajW
NeerajW previously approved these changes Dec 4, 2017
keveleigh
keveleigh previously approved these changes Dec 11, 2017
@SimonDarksideJ
Copy link
Contributor

Found 1 issue.
If I add a new machine on the Deploy options and then select Local Machine. The "Open Device Portal" button is still enabled. Which doesn't work as it points to 0.0.0.0?

Although in fairness, this should be available and point to https://localhost:50443

Thoughts @StephenHodgson ?

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Dec 18, 2017

Well, if you select local machine, then the active IP is the local one. But I should look at cleaning that up if the address isn't properly filled out.

Under the hood if the address is invalid, it doesn't do anything anyway.

Does the 50443 port number have any special significance?

@SimonDarksideJ
Copy link
Contributor

50443 is the default port assigned for Immersive Headsets I guess. Unless the port is totally random, in which case you'll need to make it configurable on the screen. Best to get a few to test and report their ports

@StephenHodgson
Copy link
Contributor Author

Why would you need to add an immersive headset to the machine options?
The local machine is the one for a local build with the immersive headsets, and it installs and runs the appx via powershell.

@SimonDarksideJ
Copy link
Contributor

Because the Device Portal is a general device portal and also works for immersive headsets :D

@StephenHodgson
Copy link
Contributor Author

I'm confused. Why do you need the device portal for a local PC machine though?
You just run, install, and do what you need right in the environment you're in.

@StephenHodgson
Copy link
Contributor Author

StephenHodgson commented Dec 18, 2017

The Build window already handles everything you need to do for the local machine. No device portal required.

@SimonDarksideJ
Copy link
Contributor

Ok, fair enough. Only thought Immersive / Local machine users might find easy access to the device portal useful as well. If we're not supporting that, then just ensure the button is only enabled for IP / HL targets :D

@StephenHodgson
Copy link
Contributor Author

If we're not supporting that, then just ensure the button is only enabled for IP / HL targets :D

I believe it should get disabled if there isn't a HoloLens detected. Let me know if this isn't the case.

@NeerajW
Copy link

NeerajW commented Jan 5, 2018

@DDReaper added you as moderator. Please accept invite.
Appreciate your review here.

@StephenHodgson StephenHodgson merged commit 84fad03 into microsoft:Dev_Working_Branch Jan 5, 2018
@StephenHodgson StephenHodgson deleted the MRTK-BuildPortalUpdates branch January 5, 2018 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants