Fade Plane and transparent Sprite Fix #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… maintain." This reverts commit 8ec2a24.
This commit moves the FadePlane to the last layer in the SortingLayers to prevent it from wiping out any transparent 2D textures.
| namespace HoloToolkit.Unity | ||
| { | ||
| // Overrides the sorting layer of all renderers and child renderers | ||
| public class SortingLayerOverride : MonoBehaviour |
There was a problem hiding this comment.
Should this be a monobehaviour or maybe an extension?
There was a problem hiding this comment.
Hmm. It could be an extension but I'd probably still want a monobehaviour to call into that extension method as I tend to just add this behavior to gameObject or prefab that I need to sort.
|
|
||
| void Start() | ||
| { | ||
| renderers = GetComponentsInChildren<Renderer>(); |
There was a problem hiding this comment.
We should check if it's null first before searching, that way we can give devs the option to serialize this into the prefab/scene.
| private Renderer[] renderers; | ||
|
|
||
|
|
||
| void Start() |
There was a problem hiding this comment.
nit; all Unity Methods should be private
| { | ||
| componentRenderer.sortingLayerName = TargetSortingLayerName; | ||
| } | ||
|
|
|
|
||
| namespace HoloToolkit.Unity | ||
| { | ||
| // Overrides the sorting layer of all renderers and child renderers |
There was a problem hiding this comment.
please use the <summary> tags
Enabled serialization of renderers and made formatting changes.
|
@StephenHodgson Made the requested changes. Thanks for reviewing. |
StephenHodgson
previously approved these changes
Jan 3, 2018
keveleigh
approved these changes
Jan 4, 2018
StephenHodgson
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The FadePlane currently wipes out transparent sprites that are not on the default sorting plane. This commit maintains the FadePlane's functionality while ensuring transparent sprites still appear by drawing the FadePlane last.
Changes
I added a class called SortingLayerOverride which I believe was sharing with me from an engineer at Microsoft awhile back. I modified it to enable you to choose to always select the last layer in the sorting layers array.
I applied this behavior to the FadePlan and set it to use the last available layer.
I did not create a bug ticket but when you use the FadePlane the transparent wipes out any transparent 2D sprite that is not on the default sorting layer. This commit fixes that issue.