Signed MixedRealityToolkit binary updates #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenHodgson
previously approved these changes
Jan 26, 2018
|
Quick Q @keveleigh , is there any advantage of updating these in the Dev Working Branch, when we already have them planned for the NameSpace Refactor? Which should merge soon. |
|
@DDReaper I think he just wants to verify they work |
I only have the sharing binaries planned to be updated in the namespace refactor branch. The rest can go directly into the dev branch, since there weren't any namespaces to be updated there. |
StephenHodgson
previously approved these changes
Jan 26, 2018
keveleigh
force-pushed
the
SignedBinaryUpdates
branch
from
708549f
to
3e08858
Compare
keveleigh
force-pushed
the
SignedBinaryUpdates
branch
from
3e08858
to
bac4ed9
Compare
|
Will not including the ARM version of the Motion Controller prevent us from building for that platform target? |
|
The motion controller DLL is only used in the editor, while built apps call the platform API directly, so we don't need to ship any UWP versions of them. |
StephenHodgson
approved these changes
Jan 30, 2018
NeerajW
approved these changes
Feb 5, 2018
This was referenced Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is a new drop from https://github.com/Microsoft/MixedRealityToolkit, adding versioning info (starting at 1.0.0.1 for this drop) to all the DLLs and EXEs, as well as digitally signing the binaries with the official Microsoft certificate for authenticity.
The updated Sharing binaries will come from #1666.
In the future, drops will happen as necessary from the native repo, instead of all at once like this.
Changes