Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Slider Value on Update - Stabilization #1799

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Send Slider Value on Update - Stabilization #1799

merged 2 commits into from
Mar 16, 2018

Conversation

Gaweph
Copy link

@Gaweph Gaweph commented Mar 7, 2018

Overview

Allows for value to be sent when invoking OnUpdateEvent method.

Changes

Can Specify a method that accepts a float

image

image

Previous behavior works correctly (specifying a method and supplying a value)

image

image

@Gaweph
Copy link
Author

Gaweph commented Mar 7, 2018

Closed old PR: #1761. Targetting the Stabilization branch as suggested by @DDReaper

@SimonDarksideJ
Copy link
Contributor

This should be considered the first PR for the next Stabilisation patch release. Thoughts @davidkline-ms / @StephenHodgson

@david-c-kline
Copy link

100% agree, @DDReaper

@SimonDarksideJ
Copy link
Contributor

Then lets delete Stabilisation now that it's merged, create the new branch from it and retarget this (and any other pending PR's, so we don't lose track.

@StephenHodgson StephenHodgson changed the base branch from Stabilization to master March 8, 2018 22:43
@SimonDarksideJ SimonDarksideJ changed the base branch from master to Patch4_Dev March 16, 2018 01:05
@david-c-kline
Copy link

the stabilization branch has been deleted and a Patch4_Dev branch created for fixes to the next release.

@david-c-kline david-c-kline merged commit a064033 into microsoft:Patch4_Dev Mar 16, 2018
@Gaweph Gaweph deleted the Stabilization branch March 23, 2018 09:10
@david-c-kline david-c-kline added this to To do in 2017.2.1.4 via automation Mar 26, 2018
@david-c-kline david-c-kline moved this from To do to Done in 2017.2.1.4 Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2017.2.1.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants