Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Patch4] Update projectversion to match the current recommended Unity release #1882

Merged
merged 4 commits into from Mar 28, 2018
Merged

[Patch4] Update projectversion to match the current recommended Unity release #1882

merged 4 commits into from Mar 28, 2018

Conversation

david-c-kline
Copy link

We are recommending 2017.2.1p, yet every user with that build sees the "do you want to update" dialog. This doesn't feel right.

Fixes: #1874

@david-c-kline david-c-kline added this to To do in 2017.2.1.4 via automation Mar 26, 2018
@david-c-kline david-c-kline changed the base branch from master to Patch4_Dev March 27, 2018 00:00
@david-c-kline david-c-kline changed the title Update projectversion to match the current recommended Unity releaser [Patch4] Update projectversion to match the current recommended Unity release Mar 27, 2018
keveleigh
keveleigh previously approved these changes Mar 27, 2018
View reviewed changes
StephenHodgson
StephenHodgson previously requested changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the Getting Started badge and MRTKVersion file as well.

The License file at the very root of the project could use a Year update as well.

@david-c-kline
Copy link
Author

@StephenHodgson, by MRTKVersion file are you meaning the Roadamp.md?

@david-c-kline
Copy link
Author

Nevermind…. I was looking in the wrong place.

StephenHodgson
StephenHodgson approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's two license files (one in the root and I've in the MRTK folder itself so a copy makes it into the unity package.

@david-c-kline david-c-kline merged commit 3b03db2 into microsoft:Patch4_Dev Mar 28, 2018
2017.2.1.4 automation moved this from To do to Done Mar 28, 2018
@david-c-kline david-c-kline deleted the unityVersion branch March 30, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keveleigh keveleigh keveleigh approved these changes

@StephenHodgson StephenHodgson StephenHodgson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
2017.2.1.4
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@david-c-kline @keveleigh @StephenHodgson @heatherbarry