Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing fixes #306

Merged
merged 11 commits into from
Nov 3, 2016
Merged

Sharing fixes #306

merged 11 commits into from
Nov 3, 2016

Commits on Oct 24, 2016

  1. Moved SessionJoined event handler registration to Start() because 

    of a race condition that led to the user never getting into a room.
    @Holo-Krzysztof
    Holo-Krzysztof committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    03faa43 View commit details
    Browse the repository at this point in the history

  2. Moved ImportExportAnchorManager init to Awake and SharingStage's Connect 

    call to Start.
    @Holo-Krzysztof
    Holo-Krzysztof committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    5a6da82 View commit details
    Browse the repository at this point in the history

  3. Fixed broken singleton implementation in SharingStage.

    @Holo-Krzysztof
    Holo-Krzysztof committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    cec0c75 View commit details
    Browse the repository at this point in the history

  4. Changed SharingStage.SharingManagerConnected to be called after we ge… 

    …t an

event from NetworkConnection instead of calling Invoke with a timer.
    @Holo-Krzysztof
    Holo-Krzysztof committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    447efbd View commit details
    Browse the repository at this point in the history

  5. Removed debug prints.

    @Holo-Krzysztof
    Holo-Krzysztof committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    b4615ac View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2016

  1. Removed obsolete line from SharingStage.

    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    687d714 View commit details
    Browse the repository at this point in the history

  2. Unhooked event handler for SharingManagerConnected on object destruct… 

    …ion.
    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 2, 2016
    Configuration menu
    Copy the full SHA
    0d5090f View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2016

  1. Private all the things!

    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    b8e46d7 View commit details
    Browse the repository at this point in the history

  2. Removed extra line.

    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    c835f8d View commit details
    Browse the repository at this point in the history

  3. Previously public members are public again.

    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    fa00b71 View commit details
    Browse the repository at this point in the history

  4. ImportExportState is now private.

    @Holo-Krzysztof
    Holo-Krzysztof committed Nov 3, 2016
    Configuration menu
    Copy the full SHA
    5b8ab53 View commit details
    Browse the repository at this point in the history