Refactor WMRUtilities to support Unity legacy XR and XR SDK #6989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for Unity backend-specific implementations
keveleigh
added
Cross Platform
Platform - Windows Mixed Reality
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
wiwei
reviewed
Jan 7, 2020
...it.Providers/WindowsMixedReality/Shared/Definitions/IWindowsMixedRealityUtilitiesProvider.cs
Show resolved
Hide resolved
wiwei
reviewed
Jan 7, 2020
Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Shared/WindowsMixedRealityUtilities.cs
Show resolved
Hide resolved
wiwei
reviewed
Jan 7, 2020
...ts/MixedRealityToolkit.Providers/WindowsMixedReality/WindowsMixedRealityUtilitiesProvider.cs
Show resolved
Hide resolved
wiwei
approved these changes
Jan 7, 2020
keveleigh
force-pushed
the
refactor-wmrutilities
branch
from
1569030
to
44b4228
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| @@ -24,12 +24,12 @@ public struct HolographicFrameNativeData | |||
| public uint MaxNumberOfCameras; | |||
|
|
|||
| /// <summary> | |||
| /// The current native root <see href="https://docs.microsoft.com/uwp/api/windows.perception.spatial.spatialcoordinatesystem">ISpatialCoordinateSystem</see>). | |||
| /// The current native root <see href="https://docs.microsoft.com/uwp/api/windows.perception.spatial.spatialcoordinatesystem">ISpatialCoordinateSystem</see>. | |||
There was a problem hiding this comment.
is this the root pointer for all native access? not sure what "root" means here
There was a problem hiding this comment.
It's the ISpatialCoordinateSystem at the root of the scene. Happy to use a different word if something else makes it more clear!
The current native root ISpatialCoordinateSystem
There was a problem hiding this comment.
ignore me.... i missed the <see ... /> part of the comment. it is fine as is
There was a problem hiding this comment.
Error:BaseWindowsMixedRealityCameraSettings.cs(54,17): error CS0246: The type or namespace name 'WindowsMixedRealityCameraSettingsProfile' could not be found (are you missing a using directive or an assembly reference?)
There was a problem hiding this comment.
@LongForever1993 Where and when are you seeing that error? Please file an issue if it's consistent.
.../MixedRealityToolkit.Providers/WindowsMixedReality/Definitions/HolographicFrameNativeData.cs
Show resolved
Hide resolved
...it.Providers/WindowsMixedReality/Shared/Definitions/IWindowsMixedRealityUtilitiesProvider.cs
Show resolved
Hide resolved
Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Shared/WindowsMixedRealityUtilities.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Shared/WindowsMixedRealityUtilities.cs
Outdated
Show resolved
Hide resolved
Assets/MixedRealityToolkit.Providers/WindowsMixedReality/Shared/WindowsMixedRealityUtilities.cs
Show resolved
Hide resolved
david-c-kline
approved these changes
Jan 7, 2020
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
keveleigh
added
the
Platform - XR SDK
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors the static
WindowsMixedRealityUtilitiesto take in a provider, which can be set in platform-specific data providers. This allows the utilities class to be called generically regardless of the Unity XR backend.Changes