Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed prefabs in interactable scene #7070

Conversation

thalbern
Copy link
Contributor

@thalbern thalbern commented Jan 15, 2020

Overview

Most elements in the interactable scene were not properly working (or triggering twice) on near interaction due to the use of TouchHandler.
I've cleaned all the prefabs up now - removed duplicate components and touchhandler and added / configured PressableButton and PhysicalPressEventRouter

Buttons should now all animate, play sound and trigger correctly as well as radial set / checkbox / toggle and their unity ui equivalents

Changes

interactable_scene2

@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@@ -165,5 +162,6 @@ PrefabInstance:
propertyPath: m_text
value: Say "Select"
objectReference: {fileID: 0}
m_RemovedComponents: []
m_RemovedComponents:
- {fileID: 5168285722132125214, guid: f15ddb9bd0bf19d478c51ea991c6a7ce, type: 3}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something that could be removed from the base prefab as well, or is its removal specific to this prefab variant?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm this is weird - i removed that component from the prefab as well - but might be related to the order i did it? - so it's definitely gone from the prefab (it's the touchhandler)
I'll revert that change and see if it just poofs away

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to manually remove it from file - i think unity got confused because I deleted it in the derived prefab first and then in the base prefab - i didn't see at first that there was another hierarchy level

@Troy-Ferrell
Copy link
Contributor

@thalbern can you update the breaking changes issue for 2.3 with list of prefabs affected? Since people with references to touchhandler etc will be broken.

@thalbern
Copy link
Contributor Author

@thalbern Bernadette Thalhammer FTE can you update the breaking changes issue for 2.3 with list of prefabs affected? Since people with references to touchhandler etc will be broken.

thanks @Troy-Ferrell - added an entry in the release notes

@keveleigh keveleigh added this to the MRTK 2.3.0 milestone Jan 15, 2020
@keveleigh
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@thalbern
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@thalbern
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@thalbern thalbern merged commit 7e72c28 into microsoft:prerelease/2.3.0_stabilization Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants