Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvements for ImportExportAnchorManager #728

Merged
merged 2 commits into from
Jul 12, 2017
Merged

improvements for ImportExportAnchorManager #728

merged 2 commits into from
Jul 12, 2017

Conversation

davesmits
Copy link

@davesmits davesmits commented Jun 16, 2017 •
edited by StephenHodgson

Fixes #652

  • sometimes InitRoomApi was called twice. this is beeing avoided now
  • GetRoomCount is giving 0 sometimes when there are rooms, causing a extra room is created. added a slight delay that seems to fix the issue

@msftclas
Copy link

@davesmits,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@davesmits
Copy link
Author

problems discussed in this issue: #652

@keveleigh
Copy link
Contributor

This looks good to me, but adding @darax for comment, since he wrote this script originally.

StephenHodgson
StephenHodgson approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@StephenHodgson StephenHodgson left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I also noticed the duplicate room sometimes. But I've written my own version since this is in the tests namespace. It locks the room anchor to a specific name.

@StephenHodgson StephenHodgson mentioned this pull request Jun 27, 2017
Merged
@keveleigh keveleigh merged commit bb54a83 into microsoft:master Jul 12, 2017
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Aug 11, 2017
@keveleigh
Merge pull request microsoft#728 from davesmits/feature/ImportExportA…
9c51581 
…nchorManagerImprovement

improvements for ImportExportAnchorManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keveleigh keveleigh keveleigh approved these changes

@StephenHodgson StephenHodgson StephenHodgson approved these changes

@darax darax Awaiting requested review from darax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davesmits @msftclas @keveleigh @StephenHodgson