Made NonNativeKeyboard touchable #7611
Conversation
|
|
||
| namespace Microsoft.MixedReality.Toolkit.Experimental.UI | ||
| { | ||
| public class NonNativeKeyboardTouchAssistant : MonoBehaviour |
There was a problem hiding this comment.
Might be good to make this script run at edit time. No need to add these components at runtime.
There was a problem hiding this comment.
It's not like this a very heavy procedure and I am not quite a fan of modifying things at edit time. Messing with the internals of the keyboard changes the scene permanently, not sure if I would like that
There was a problem hiding this comment.
I guess my preference is to simply permanently modify the prefab, rather than having a modifier that adds it. I understand both perspectives though
There was a problem hiding this comment.
Is there a downside to just updating the prefab to contain all the relevant NearInteractionTouchableUnityUI and audioclip components? And leaving them there regardless of if touch is supported? Especially if this script is already being added to the prefab by default
There was a problem hiding this comment.
You might not always want this, and this way it's easy to disable it.
| var buttons = GetComponentsInChildren<Button>(); | ||
| foreach (var button in buttons) | ||
| { | ||
| var ni = button.gameObject.AddComponent<NearInteractionTouchableUnityUI>(); |
There was a problem hiding this comment.
You should maybe use EnsureComponent instead of Add. Add makes it so that these things might be duplicated.
|
|
||
| private void EnableTouch() | ||
| { | ||
| _clickSoundPlayer = gameObject.AddComponent<AudioSource>(); |
There was a problem hiding this comment.
Ensure component here too
There was a problem hiding this comment.
Nope. That might mess up an existing AudioSource component and fill it with my sound file. This is intentional
Assets/MRTK/SDK/Experimental/NonNativeKeyboard/Scripts/NonNativeKeyboardTouchAssistant.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/SDK/Experimental/NonNativeKeyboard/Scripts/NonNativeKeyboardTouchAssistant.cs
Outdated
Show resolved
Hide resolved
Assets/MRTK/SDK/Experimental/NonNativeKeyboard/Scripts/NonNativeKeyboardTouchAssistant.cs
Outdated
Show resolved
Hide resolved
|
|
||
| namespace Microsoft.MixedReality.Toolkit.Experimental.UI | ||
| { | ||
| public class NonNativeKeyboardTouchAssistant : MonoBehaviour |
There was a problem hiding this comment.
Please add a summary and the AddComponentMenu attribute here.
There was a problem hiding this comment.
Summary, okay, but it's already on the prefab, as suggested by @provencher in the Slack channel. You are not going to add this thing to anything - at most you are going to disable it. At least, that was my idea
keveleigh
added
Input - Keyboard
UX Controls - Non Native Keyboard
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Overview
This makes the nonnative keyboard prefab respond to touch events
Changes
Added a new behaviour NonNativeKeyboardTouchAssistant to the NonNativeKeyboard that enables touch when articulated hand support is detected. By request of @provencher after reading http://dotnetbyexample.blogspot.com/2020/04/migrating-to-mrtk2-using-non-native.html