Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GazeManager uGUI raycast calculations & GazeTransform initialization #805

Merged
merged 3 commits into from
Aug 2, 2017
Merged

Updated GazeManager uGUI raycast calculations & GazeTransform initialization #805

merged 3 commits into from
Aug 2, 2017

Conversation

StephenHodgson
Copy link
Contributor

@StephenHodgson StephenHodgson commented Jul 26, 2017 •
edited

@StephenHodgson
Fixed issue where uGUI raycasting was compensating for Unity Bug. Uni…
129b1cd 
…ty now correctly calculates from the nearclip plane.
@StephenHodgson
fixed minor typo in private method. no breaking changes.
6166bd3
@StephenHodgson
Fixed typo in method summary.
ceafcf5 
Updated GazeTransform assignment from Awake to Start, moved it into its own method and check it during update.
@StephenHodgson StephenHodgson changed the title Updated GazeManager uGUI raycast calculations. Updated GazeManager uGUI raycast calculations & GazeTransform initialization Jul 26, 2017
@NeerajW NeerajW requested a review from keveleigh July 31, 2017 18:48
@StephenHodgson StephenHodgson mentioned this pull request Aug 1, 2017
Closed
ForrestTrepte
ForrestTrepte approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@ForrestTrepte ForrestTrepte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@StephenHodgson StephenHodgson merged commit f61436f into microsoft:master Aug 2, 2017
@StephenHodgson StephenHodgson deleted the HTK-uGUIRaycast branch August 3, 2017 16:02
keveleigh pushed a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Aug 11, 2017
@StephenHodgson @keveleigh
Merge pull request microsoft#805 from StephenHodgson/HTK-uGUIRaycast
1a4dd6f 
Updated GazeManager uGUI raycast calculations & GazeTransform initialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeerajW NeerajW NeerajW approved these changes

@ForrestTrepte ForrestTrepte ForrestTrepte approved these changes

@maxouellet maxouellet Awaiting requested review from maxouellet

@keveleigh keveleigh Awaiting requested review from keveleigh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@StephenHodgson @NeerajW @ForrestTrepte @msftclas