-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added confidence level for the keyword recognizer #927
Added confidence level for the keyword recognizer #927
Conversation
…e and assosiated editor script.
@cybergoulion, It will cover your contributions to all Microsoft-managed open source projects. |
@@ -59,8 +62,8 @@ protected override void Start() | |||
{ | |||
keywords[index] = Keywords[index].Keyword; | |||
} | |||
|
|||
keywordRecognizer = new KeywordRecognizer(keywords); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove line changes. (seems to have added extra spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, as this is my first pull request, is this something I should fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all you have to do is push the changes to your branch and they'll automatically show up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cybergoulion Just always hit ctrl+k+d in visual studio to fix formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces removed and recommited. I see the changes here so I guess I did it. Well it went smooth for the first time :-)
Thanks for the help.
@cybergoulion, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Fixes #925
Added confidence level for the keyword recognizer in SpeechInputSource and assosiated editor script.