Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added confidence level for the keyword recognizer #927

Merged
merged 2 commits into from
Sep 4, 2017

Conversation

cybergoulion
Copy link

@cybergoulion cybergoulion commented Sep 4, 2017

Fixes #925

Added confidence level for the keyword recognizer in SpeechInputSource and assosiated editor script.
speechinputsource

@msftclas
Copy link

msftclas commented Sep 4, 2017

@cybergoulion,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@@ -59,8 +62,8 @@ protected override void Start()
{
keywords[index] = Keywords[index].Keyword;
}

keywordRecognizer = new KeywordRecognizer(keywords);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: remove line changes. (seems to have added extra spaces)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, as this is my first pull request, is this something I should fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, all you have to do is push the changes to your branch and they'll automatically show up here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cybergoulion Just always hit ctrl+k+d in visual studio to fix formatting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces removed and recommited. I see the changes here so I guess I did it. Well it went smooth for the first time :-)
Thanks for the help.

@msftclas
Copy link

msftclas commented Sep 4, 2017

@cybergoulion, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@StephenHodgson StephenHodgson merged commit 333f6d5 into microsoft:master Sep 4, 2017
@cybergoulion cybergoulion deleted the SpeechInputConfidence branch September 4, 2017 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants