New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assorted Unity improvements #9940
Merged
keveleigh
merged 3 commits into
microsoft:main
from
keveleigh:assorted-unity-improvements
Jun 15, 2021
Merged
Assorted Unity improvements #9940
keveleigh
merged 3 commits into
microsoft:main
from
keveleigh:assorted-unity-improvements
Jun 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which isn't best practice due to Unity's custom == operators
keveleigh
added
the
Code Style
Issues related to code style guidelines and robustness
label
Jun 7, 2021
keveleigh
requested review from
CDiaz-MS,
david-c-kline and
julenka
as code owners
June 7, 2021 22:44
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
MaxWang-MS
approved these changes
Jun 15, 2021
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…vements Assorted Unity improvements
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…vements Assorted Unity improvements
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…vements Assorted Unity improvements
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
…vements Assorted Unity improvements
keveleigh
added a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
…vements Assorted Unity improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
?.
on ScriptableObjects, which isn't supported due to Unity's custom == operator.#if
to not leave an empty method behindnew
ing it