Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted Unity improvements #9940

Merged
merged 3 commits into from Jun 15, 2021

Conversation

keveleigh
Copy link
Contributor

Overview

  1. Removes some uses of ?. on ScriptableObjects, which isn't supported due to Unity's custom == operator.
  2. Rescopes an #if to not leave an empty method behind
  3. Updates a test to use Unity's methods for creating a ScriptableObject instead of newing it

@keveleigh keveleigh added the Code Style Issues related to code style guidelines and robustness label Jun 7, 2021
@keveleigh keveleigh added this to the MRTK 2.x future milestone Jun 7, 2021
@keveleigh keveleigh requested a review from RogPodge June 7, 2021 22:44
@keveleigh keveleigh self-assigned this Jun 7, 2021
@keveleigh
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@keveleigh keveleigh merged commit d2329b6 into microsoft:main Jun 15, 2021
@keveleigh keveleigh deleted the assorted-unity-improvements branch June 15, 2021 20:00
@polar-kev polar-kev modified the milestones: MRTK 2.x future, MRTK 2.7.3 Nov 22, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 7, 2021
keveleigh added a commit to keveleigh/HoloToolkit-Unity that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Issues related to code style guidelines and robustness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants