Disabled components no longer focus lock pointers. #9945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to become focus locked
RogPodge
requested review from
CDiaz-MS,
david-c-kline,
julenka and
keveleigh
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
keveleigh
approved these changes
Jun 8, 2021
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
… to become focus locked (microsoft#9945)
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
… to become focus locked (microsoft#9945)
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
… to become focus locked (microsoft#9945)
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 7, 2021
… to become focus locked (microsoft#9945)
keveleigh
pushed a commit
to keveleigh/HoloToolkit-Unity
that referenced
this pull request
Dec 8, 2021
… to become focus locked (microsoft#9945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
To check if a pointer is focus locked, we see if there are any IMixedRealityPointerHandler when the OnPointerDown event is raised.
This PR fixes an edge case where an component implements that interface, but is itself disabled.
Changes