Skip to content
This repository has been archived by the owner on Jan 26, 2021. It is now read-only.

reserved identifier violation #2

Closed
elfring opened this issue Nov 10, 2015 · 3 comments
Closed

reserved identifier violation #2

elfring opened this issue Nov 10, 2015 · 3 comments

Comments

@elfring
Copy link

elfring commented Nov 10, 2015

I would like to point out that identifiers like "_MULTIVERSO_BARRIER_H_" and "_MULTIVERSO_SERVER_H_" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@chivee
Copy link
Contributor

chivee commented Nov 10, 2015

Thanks for your suggestion.

We will adjust the macros.

@chivee chivee closed this as completed Nov 10, 2015
@elfring
Copy link
Author

elfring commented Nov 10, 2015

Would it be better to leave this issue open until the affected implementation details will be fixed?

@chivee chivee reopened this Nov 10, 2015
@chivee chivee closed this as completed Nov 10, 2015
@elfring
Copy link
Author

elfring commented Nov 10, 2015

Thanks for your improvement of affected include guards.

liming-vie added a commit that referenced this issue Aug 15, 2016
@liming-vie
Merge pull request #2 from Microsoft/master
450d46b 
Merge from Microsoft/multiverso
@tangzhenyu tangzhenyu mentioned this issue Feb 14, 2017
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @chivee