Fix concat in interaction layer. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 15, 2019 19:03
added 3 commits
May 28, 2019 10:47
adolphk-yk
reviewed
Jun 13, 2019
block_zoo/Pooling2d.py
Outdated
|
|
||
| assert self.output_dim[-1] != -1, "The shape of input is %s , and the input channel number of pooling should not be -1." % (str(self.input_dims[0])) | ||
|
|
||
| class Pooling2D(BaseLayer): |
There was a problem hiding this comment.
Hi, if you modify a layer's name, you should modify corresponding name in block_zoo/init.py. thanks.
adolphk-yk
reviewed
Jun 13, 2019
block_zoo/Conv2d.py
Outdated
| self.add_attr_exist_assertion_for_user(attr) | ||
|
|
||
|
|
||
| class Conv2D(BaseLayer): |
There was a problem hiding this comment.
Hi, if you modify a layer's name, you should modify corresponding name in block_zoo/init.py. Thanks.
There was a problem hiding this comment.
This is because I use Conv2d first and then convert to Conv2D, I have deleted Conv2d and Pooling2d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix concat in interaction layer.