Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Use environment markers instead of modifying _install_requires #238

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ianlini
Copy link

@ianlini ianlini commented Aug 20, 2019

Fixes #237.

Please see #237 for more information.

@ianlini
Copy link
Author

ianlini commented Aug 20, 2019

The Windows Py35 pipeline failed when installing enum. I have tried to install my version of nimbusml using Python 3.5.7 with pyenv and ubuntu 18.04. The result is correct and the dependencies shouldn't include enum. I have no idea why the pipeline try to install enum.

@msftclas
Copy link

msftclas commented Jan 10, 2020

CLA assistant check
All CLA requirements met.

@ianlini
Copy link
Author

ianlini commented Jan 10, 2020

After a few hours of investigation, I found that the environment marker syntax I used may be wrong in the Py35 environment. Luckily, after upgrading setuptools, the problem is resolved. It's actually quite usual to upgrade pip, setuptools and wheel before doing anything.

@ianlini
Copy link
Author

ianlini commented Jan 10, 2020

@ganik Could you take a look at this old PR?

@ianlini
Copy link
Author

ianlini commented Feb 13, 2020

@pieths Could you take a look at this old PR? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use environment markers in setup.py
2 participants