Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Make Python 3.7 non-support explicit. #28

Merged
merged 1 commit into from
Oct 29, 2018
Merged

Conversation

montebhoover
Copy link
Contributor

Fixes #20 .

@stevengum
Copy link
Member

stevengum commented Oct 29, 2018

@montebhoover What is in your team's plan around support for 3.7? The BotBuilder SDK team is considering moving to Python 3.7 from 3.6; we'd like to be able to run with NimbusML out of the box, should customers decide to use the two together.

DCR: Target Python 3.7 instead of Python 3.6 for BotBuilder-Python [microsoft/botframework-sdk#5112]

@montebhoover
Copy link
Contributor Author

montebhoover commented Oct 29, 2018

@GalOshri The BotBuilder SDK team was asking where NimbusML support for python 3.7 falls on our roadmap for use in their planning.

@montebhoover montebhoover merged commit 2350069 into master Oct 29, 2018
@montebhoover montebhoover deleted the montebhoover/no_py37 branch November 2, 2018 21:25
@amueller
Copy link
Collaborator

amueller commented Nov 7, 2018

awww. What's the issue?

@montebhoover
Copy link
Contributor Author

@xadupre I think you explored this a while back - do you have a guess on how much time it would take to get NimbusML supporting Python 3.7?

@amueller
Copy link
Collaborator

amueller commented Nov 7, 2018

I should probably have asked on #37, sorry. 3.7 is the current version of Python and not supporting it seems a major drawback. The other thread mentions major problems with 3.7. Can you elaborate? I have not heard about any issues with 3.7 so far and we had not issue supporting it in sklearn.

@xadupre
Copy link
Member

xadupre commented Nov 7, 2018

I created a branch where I made the necessary changes to compile nimbusml for python3.7 on windows. linux and mac are easy to add but I could not test them (just need to modify csproj and sln files).

https://github.com/Microsoft/NimbusML/tree/py37_11

But:

  • I did not want to build with boostpython as it seemed complex to retrieve the necessary binaries, I replaced it with pybind11.
  • I used the python standard distribution instead of anaconda (that should not change anything).
  • I did not run the whole test series (but so far no issues for the examples I tried)
  • The build is not yet finalized as I had to copy ml.net binaries myself to .internal.libs

Conclusion:

  • It is almost done.
  • CI and build must be completed.
  • I can share the wheel I built on Windows based on the branch mentioned above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants