Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Remove code wrapping within URL #46

Closed

Conversation

justinormont
Copy link
Contributor

The wrapping of the URL seems to be adding an extra space in the rendered doc's version of the URL:

extraspace

Rendered docs: https://docs.microsoft.com/en-us/python/api/nimbusml/nimbusml.cluster.kmeansplusplus?view=nimbusml-py-latest#remarks

The wrapping of the URL seems to be adding an extra space in the rendered doc's version of the URL: https://docs.microsoft.com/en-us/python/api/nimbusml/nimbusml.cluster.kmeansplusplus?view=nimbusml-py-latest#remarks
@justinormont
Copy link
Contributor Author

Closing/re-opening to restart CI tests

@justinormont justinormont reopened this Nov 2, 2018
@montebhoover
Copy link
Contributor

montebhoover commented Nov 2, 2018

I'm looking at why the build failed here and it brings up something I'll need to document. The file with the docstring you are fixing is autogenerated, and the build fails when checking to see if the autogenerated files are consistent with what we expect.

I'll need to document this better, but
kmeansplusplus.py is autogenerated based on the ML.NET nuget and a docstring text file: KMeansPlusPlus.txt. So the end to end process for this change is to:

  1. edit KMeansPlusPlus.txt,
  2. run entrypoint_compiler.py locally which will produce kmeansplusplus.py with your change reflected in the docstring,
  3. make a PR with both the edited text file and the edited autogenerated file.

This will allow the build to pass when verifying our autogenerated files are consistent with docstring text files + ML.NET nuget.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants