Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Da/component updates #65

Merged
merged 27 commits into from
Jul 28, 2021
Merged

Da/component updates #65

merged 27 commits into from
Jul 28, 2021

Conversation

gfs
Copy link
Contributor

@gfs gfs commented Jul 15, 2021

Fix #68
Fix #69
Fix #66
Fix #67

gfs added 3 commits July 16, 2021 10:31
Now works with nullable enums that are default to null.
Copy link
Contributor

@daalcant daalcant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gfs added 6 commits July 21, 2021 12:03
Issues:
Many elements cannot be clicked on, but can be tabbed to and used.
Icons images are not sized correctly.
…supported.

Fixes setting values in dictionaries.
We cannot actually check if reference types are nullable so we need to check if the value is null and show the checkbox when it is null.

We do not show the checkbox if the value is no longer null and we can't confirm that its nullable.
@gfs
Copy link
Contributor Author

gfs commented Jul 27, 2021

Failing check appears to be CodeQL complaining about stuff from .NET in the blazor build.

@gfs gfs merged commit 08f3767 into main Jul 28, 2021
@gfs gfs deleted the da/component-updates branch July 28, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment