Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated omsagent installation guide for post install onboarding #185

Merged
merged 1 commit into from
Sep 2, 2016

Conversation

NarineM
Copy link
Contributor

@NarineM NarineM commented Sep 2, 2016

Updated oms agent installation guide for post install onboarding to use service_control enable to register omsagent and restart the service altogether. Per current design, oms agent service restart no longer works since at the time it is called (right after onboarding using cmdline or a file) the agent is not registered as a service.
@Microsoft/omsagent-devs

… use service-control to register the omsagent svc
3. Restart the omsagent:
`sudo service omsagent restart`
3. Register the omsagent service and restart:
`sudo ./service_control enable`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe specify the full path of the script

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. You still want to use the restart command.

The restart command will register the service, enable the service (or it should upon registration), and then start the service. This is what you want.

If you simply enable it, that will enable restarting the service at reboot time, which is a subset of what you want.

Another iteration please, or just throw this away since existing code should be fine. If not, then another iteration please.

@niroyb
Copy link
Contributor

niroyb commented Sep 2, 2016

Signed off

@NarineM NarineM merged commit c385634 into master Sep 2, 2016
@jeffaco
Copy link
Contributor

jeffaco commented Sep 2, 2016

NOT signed off, see my comments.

@NarineM
Copy link
Contributor Author

NarineM commented Sep 2, 2016

As per discussion, this is a doc change to be in sync with the current design since it is used by end user and current steps do not work. The user gets "service does not exist " error. Once the product is changed, the user documentation would need to be updated to be in sync with the new changes.

@NarineM NarineM deleted the narinem-agentinstall-doc-makeruby branch September 2, 2016 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants