Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix codeql issues #1084

Merged
merged 5 commits into from
Apr 17, 2024
Merged

fix codeql issues #1084

merged 5 commits into from
Apr 17, 2024

Conversation

guotuofeng
Copy link
Collaborator

@guotuofeng guotuofeng commented Apr 17, 2024 •
edited

Describe your changes

Checklist before requesting a review

  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.
  • Add unit tests for this change.

(Optional) Issue link

@guotuofeng guotuofeng merged commit 380cbe5 into main Apr 17, 2024
35 checks passed
@guotuofeng guotuofeng deleted the myguo/nit branch April 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trajepl trajepl trajepl left review comments

@jambayk jambayk jambayk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guotuofeng @trajepl @jambayk