Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeQL: Fix FileListDataLoader #1085

Merged
merged 2 commits into from
Apr 17, 2024
Merged

CodeQL: Fix FileListDataLoader #1085

merged 2 commits into from
Apr 17, 2024

Conversation

jambayk
Copy link
Contributor

@jambayk jambayk commented Apr 17, 2024

Describe your changes

The subclasses override load_data method which generates the following warning
image

Fixed by the loading the data beforehand and passing the required data parameters to super init.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

trajepl
trajepl previously approved these changes Apr 17, 2024
Copy link
Collaborator

@guotuofeng guotuofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems a creator is another better way?

@jambayk jambayk merged commit 5baacf7 into main Apr 17, 2024
35 checks passed
@jambayk jambayk deleted the jambayk/raw-dl branch April 17, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants