Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write configs as part of conversion pass #1089

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Write configs as part of conversion pass #1089

merged 1 commit into from
Apr 19, 2024

Conversation

shaahji
Copy link
Contributor

@shaahji shaahji commented Apr 17, 2024

Write configs as part of conversion pass

For generative models using GenAI model builder, when using ONNX model as input configs (config.json, generation_config.json & tokenizer) are required inputs. So, write out these files as outputs from the conversion pass.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@shaahji shaahji marked this pull request as draft April 17, 2024 21:14
@shaahji shaahji marked this pull request as ready for review April 18, 2024 22:56
@shaahji shaahji force-pushed the shaahji/genaicfgs branch 2 times, most recently from 3498962 to b49c8a4 Compare April 19, 2024 01:53
For generative models using GenAI model builder, when using ONNX model
as input configs (config.json, generation_config.json & tokenizer) are
required inputs. So, write out these files as outputs from the
conversion pass.
Copy link
Contributor

@jambayk jambayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you abstract some of the common code like file -> parent_dir in the follow up PR?

@shaahji shaahji merged commit c686733 into main Apr 19, 2024
35 checks passed
@shaahji shaahji deleted the shaahji/genaicfgs branch April 19, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants