Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌵 Olive kv_cache_config under io_config #1121

Merged
merged 10 commits into from
May 7, 2024
Merged

Conversation

trajepl
Copy link
Contributor

@trajepl trajepl commented Apr 28, 2024

Describe your changes

  1. Add the option of kv_cache_config in io_config:
    • kv_cache_config: None or False, will not enable kv cache
    • kv_cahce_config: True or dict, will generate related kv_cache input based on existed io_config and model attributes.
      • Suggest to set True for huggingface transformer models
      • Suggest to set dict for non-huggingface models
  2. Update phi2/llama2 example by removing io_config/dummy_inputs_func from user_scirpts and config json.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link
Collaborator

@guotuofeng guotuofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better allow specify the kv cache if user would like keep using io_config function.

@jambayk jambayk changed the title 🌵 Olive kv_cahe_config under io_config 🌵 Olive kv_cache_config under io_config May 3, 2024
@trajepl trajepl merged commit 150bae1 into main May 7, 2024
35 checks passed
@trajepl trajepl deleted the jiapli/built_in_kv_config branch May 7, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants