-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Olive Command Line Tools #1129
Olive Command Line Tools #1129
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
use sys.executable to call
nit separate configure implementation from call to fix codeql cyclic import Revert "separate configure implementation from call to fix codeql cyclic import" This reverts commit 3c858a8. remove main from impl file unused import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are touching so many of the documentation files, I would recommend adding the language for the commands as well. A lot of them are missing.
Instead of wrapping ``` .... ``` it should be ```sh ..... ```. Or optionally yse bash
Describe your changes
This PR adds command line tools for Olive that can be called using
olive
orpython -m olive
command.python -m olive.workflows.run
andpython -m olive.platform_sdk.qualcomm.configure
are deprecated and will emit a FutureWarning.olive.cli
sub-module. These must handle the command parsing and, in some cases, the implementation of the command too.olive.workflows.snpe
sub-module since the code is outdated and obsolete.sphinx-argparse
extension:Checklist before requesting a review
lintrunner -a
olive
command line tool has been added.olive run
orpython -m olive
instead ofpython -m olive.workflows.run
which has been deprecated.(Optional) Issue link