Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemma to DML LLM sample #1138

Merged
merged 2 commits into from
May 6, 2024
Merged

Conversation

PatriceVignola
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

trajepl
trajepl previously approved these changes May 6, 2024
@PatriceVignola PatriceVignola merged commit 63c0430 into main May 6, 2024
7 checks passed
@PatriceVignola PatriceVignola deleted the user/pavignol/add-gemma-dml-example branch May 6, 2024 17:19
@ErsongWang
Copy link

The type of config.head_dim will be changed to float from it. And it caused TypeError on my side. TypeError: empty() received an invalid combination of arguments

jambayk pushed a commit that referenced this pull request May 15, 2024
fix `config.head_dim` to `int` type. The changes in #1138 made the
head_dim param to type `float`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants