Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnnxIOFloat16ToFloat32 Pass #1149

Merged
merged 20 commits into from
May 15, 2024
Merged

Add OnnxIOFloat16ToFloat32 Pass #1149

merged 20 commits into from
May 15, 2024

Conversation

xiaoyu-work
Copy link
Contributor

Describe your changes

Add OnnxIOFloat16ToFloat32 Pass

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.
  • Is this PR including examples changes? If yes, please remember to update example documentation in a follow-up PR.

(Optional) Issue link

@xiaoyu-work xiaoyu-work marked this pull request as ready for review May 13, 2024 08:26
github-advanced-security[bot]
github-advanced-security bot found potential problems May 13, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

jambayk
jambayk reviewed May 13, 2024
View reviewed changes
docs/source/api/passes.rst Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2024
View reviewed changes
examples/phi3/phi3.py Fixed Show fixed Hide fixed
examples/phi3/phi3.py Fixed Show fixed Hide fixed
examples/phi3/phi3.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2024
View reviewed changes
examples/phi3/phi3.py Fixed Show fixed Hide fixed
jambayk
jambayk reviewed May 14, 2024
View reviewed changes
examples/phi3/phi3.py Outdated Show resolved Hide resolved
jambayk
jambayk reviewed May 14, 2024
View reviewed changes
examples/phi3/phi3.py Outdated Show resolved Hide resolved
jambayk
jambayk reviewed May 14, 2024
View reviewed changes
examples/phi3/phi3.py Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2024
View reviewed changes
examples/phi3/phi3.py Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems May 14, 2024
View reviewed changes
examples/phi3/phi3.py Fixed Show fixed Hide fixed
examples/phi3/phi3.py Fixed Show fixed Hide fixed
examples/phi3/phi3.py Fixed Show fixed Hide fixed
jambayk
jambayk reviewed May 14, 2024
View reviewed changes
examples/phi3/phi3.py Outdated Show resolved Hide resolved
jambayk
jambayk reviewed May 14, 2024
View reviewed changes
examples/phi3/phi3.py Outdated Show resolved Hide resolved
@xiaoyu-work xiaoyu-work merged commit 5cbf989 into main May 15, 2024
35 checks passed
@xiaoyu-work xiaoyu-work deleted the dpatel/webgpu branch May 15, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guschmue guschmue guschmue left review comments

@devang-ml devang-ml devang-ml left review comments

@jambayk jambayk jambayk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xiaoyu-work @guschmue @devang-ml @jambayk @Emma1807