Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip docker system test for bert example #239

Merged
merged 2 commits into from
May 4, 2023
Merged

Skip docker system test for bert example #239

merged 2 commits into from
May 4, 2023

Conversation

xiaoyu-work
Copy link
Contributor

Describe your changes

Skip docker system test for bert example until bug is fixed: docker/docker-py#3113

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Format your code by running pre-commit run --all-files

(Optional) Issue link

Copy link
Contributor

@jambayk jambayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think if the next docker release is going to take time, we might have to do the temporary solution of pinning urllib3 and requests for docker extra to make docker system usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

urllib3 v2 incompatibility
2 participants