Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add openllama arc example #582

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Add openllama arc example #582

merged 3 commits into from
Sep 22, 2023

Conversation

xiaoyu-work
Copy link
Contributor

@xiaoyu-work xiaoyu-work commented Sep 19, 2023 •
edited

Describe your changes

  • Add openllama arc example

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Format your code by running pre-commit run --all-files
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@xiaoyu-work
Copy link
Contributor Author

Will update documentation shortly

@xiaoyu-work
Copy link
Contributor Author

There should be a bug about multiple EP. Will take a look later.

guotuofeng
guotuofeng reviewed Sep 20, 2023
View reviewed changes
olive/engine/engine.py Outdated Show resolved Hide resolved
guotuofeng
guotuofeng requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@guotuofeng guotuofeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the engine change need be reverted.

Please refer to c8bf690 for more information

jambayk
jambayk previously approved these changes Sep 21, 2023
View reviewed changes
@xiaoyu-work xiaoyu-work merged commit 93a9abc into main Sep 22, 2023
29 checks passed
@guotuofeng guotuofeng deleted the xiaoyu/shiproom2 branch September 24, 2023 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guotuofeng guotuofeng guotuofeng approved these changes

@jambayk jambayk jambayk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaoyu-work @guotuofeng @jambayk