Add microsoft\phi_1 example #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
jambayk
reviewed
Nov 3, 2023
jambayk
reviewed
Nov 3, 2023
jambayk
reviewed
Nov 3, 2023
guotuofeng
reviewed
Nov 5, 2023
|
|
||
| ``` | ||
| python .\optimize.py --inference | ||
| def print_prime(n): |
There was a problem hiding this comment.
the indentation should be same for two defs? #Resolved
guotuofeng
reviewed
Nov 5, 2023
examples/directml/phi/README.md
Outdated
| ``` | ||
| # sample inputs | ||
| inputs = tokenizer('''def print_prime(n): | ||
| """ |
There was a problem hiding this comment.
the left whitespace should be four? #Resolved
| } | ||
| print(f"Unoptimized Model : {model_info['unoptimized']['path']}") | ||
|
|
||
| # Create a copy of the unoptimized model directory, then overwrite with optimized models from the olive cache. |
There was a problem hiding this comment.
We don't have the optimized models yet, so we can get rid of the second part of the sentence. #Resolved
PatriceVignola
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.