Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DistributedPyTorchModel #694

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Implement DistributedPyTorchModel #694

merged 1 commit into from
Nov 6, 2023

Conversation

shaahji
Copy link
Contributor

@shaahji shaahji commented Nov 3, 2023

Description

Implement DistributedPyTorchModel

DistributedPyTorchModel is parallel to DistributedOnnxModel for PyTorch models.
Also, introducing an example, Llama2, as an use case.

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Format your code by running pre-commit run --all-files
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintrunner found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@jambayk
Copy link
Contributor

jambayk commented Nov 3, 2023

The lintrunner instructions are at https://github.com/microsoft/Olive/blob/main/CONTRIBUTING.md#linting

I find the MYPY linter to be slow, so I skip it using the following:

lintrunner --skip MYPY -a

@shaahji shaahji force-pushed the shaahji/distpy branch 2 times, most recently from fe6b06d to 7dd2408 Compare November 5, 2023 06:54
DistributedPyTorchModel is parallel to DistributedOnnxModel for PyTorch models.

Also, introducing an example, Llama2, as an use case.
@shaahji shaahji merged commit 451ab39 into main Nov 6, 2023
31 checks passed
@shaahji shaahji deleted the shaahji/distpy branch November 6, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants