-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add llama2 notebook tutorial #798
Conversation
Please fix the typos detected by the spell checker |
Fixed. |
It got a little hard to review the ipynb file changes. I noticed that most of content in jupyter note is about config files. Also not many runtime logs are showed to user. Do you mind to convert it to markdown file? |
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"# Olive tutorial Llama2\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olive Tutorial Llama2 on Azure Machine Learning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@@ -0,0 +1,164 @@ | |||
{ | |||
"azureml_client": { | |||
"subscription_id": "3905431d-c062-4c17-8fd9-c51f89f334c4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we hide these kind of info?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I'll remove that.
c14b8c2
to
488340f
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Yeah, I knew this. But it is hard to add comment to right place. ReviewNB looks great to me. Curious that is the ReviewNB suggested by copilot or something else? |
Describe your changes
Add llama2 notebook tutorial
Checklist before requesting a review
lintrunner -a
(Optional) Issue link