Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add llama2 notebook tutorial #798

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Add llama2 notebook tutorial #798

merged 3 commits into from
Dec 13, 2023

Conversation

xiaoyu-work
Copy link
Contributor

Describe your changes

Add llama2 notebook tutorial

Checklist before requesting a review

  • Add unit tests for this change.
  • Make sure all tests can pass.
  • Update documents if necessary.
  • Lint and apply fixes to your code by running lintrunner -a
  • Is this a user-facing change? If yes, give a description of this change to be included in the release notes.

(Optional) Issue link

@guotuofeng
Copy link
Collaborator

Please fix the typos detected by the spell checker

@xiaoyu-work
Copy link
Contributor Author

Please fix the typos detected by the spell checker

Fixed.

@trajepl
Copy link
Contributor

trajepl commented Dec 9, 2023

It got a little hard to review the ipynb file changes. I noticed that most of content in jupyter note is about config files. Also not many runtime logs are showed to user. Do you mind to convert it to markdown file?

"cell_type": "markdown",
"metadata": {},
"source": [
"# Olive tutorial Llama2\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olive Tutorial Llama2 on Azure Machine Learning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -0,0 +1,164 @@
{
"azureml_client": {
"subscription_id": "3905431d-c062-4c17-8fd9-c51f89f334c4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hide these kind of info?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I'll remove that.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xiaoyu-work
Copy link
Contributor Author

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@trajepl please check this link to review notebook.

@guotuofeng
Copy link
Collaborator

It got a little hard to review the ipynb file changes. I noticed that most of content in jupyter note is about config files. Also not many runtime logs are showed to user. Do you mind to convert it to markdown file?

you can try https://github.com/microsoft/Olive/blob/488340f73648d5d8ea482107facafa47f355b034/examples/notebooks/llama2/notebook.ipynb

@trajepl
Copy link
Contributor

trajepl commented Dec 11, 2023

https://github.com/microsoft/Olive/blob/488340f73648d5d8ea482107facafa47f355b034/examples/notebooks/llama2/notebook.ipynb

Yeah, I knew this. But it is hard to add comment to right place. ReviewNB looks great to me.

Curious that is the ReviewNB suggested by copilot or something else?

trajepl
trajepl previously approved these changes Dec 11, 2023
@xiaoyu-work xiaoyu-work merged commit a8c10eb into main Dec 13, 2023
32 checks passed
@xiaoyu-work xiaoyu-work deleted the xiaoyu/shiproom3 branch December 13, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants