Add Stable Diffusion OpenVINO example #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jambayk
reviewed
Jan 3, 2024
jambayk
previously requested changes
Jan 3, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jambayk
reviewed
Jan 3, 2024
jambayk
reviewed
Jan 3, 2024
| "engine": { | ||
| "search_strategy": false, | ||
| "evaluate_input_model": false, | ||
| "host": "local_system", |
There was a problem hiding this comment.
nit: both the host and local system are redundant since it's the default.
There was a problem hiding this comment.
Yeah since this is an example for user, I would like to make it clear.
jambayk
approved these changes
Jan 3, 2024
guotuofeng
reviewed
Jan 4, 2024
| @@ -74,6 +74,10 @@ def __init__( | |||
| self.objective_dict = objective_dict or {} | |||
| self.is_marked_pareto_frontier = is_marked_pareto_frontier | |||
|
|
|||
| def get_output_model_path(self): | |||
There was a problem hiding this comment.
I don't see where it is used. could you please help clarify the changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add Stable Diffusion OpenVINO example.
Next step:
examples/stable_diffusionandexamples/directml/stable_diffusion, or rewrite the README.md to link each other.Checklist before requesting a review
lintrunner -a(Optional) Issue link