-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass to export a PyTorch model using GenAI exporter #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devang-ml
reviewed
Feb 14, 2024
jambayk
reviewed
Feb 15, 2024
jambayk
reviewed
Feb 15, 2024
shaahji
force-pushed
the
shaahji/genai
branch
from
February 15, 2024 20:30
5135685
to
3065fb5
Compare
xiaoyu-work
reviewed
Feb 16, 2024
kunal-vaishnavi
added a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
Feb 22, 2024
### Description This PR enhances the model builder tool for building and running models by adding the following. - Adds a README file to show how to use the tool - Creates a GenAI JSON config file that users can customize - Saves the tokenization files from Hugging Face - Adds additional options for customizing how the model is built - Allows mini models to be created for testing purposes - Rewrites `create_model` for integration with Olive ### Motivation and Context - The README file showcases the tool's full usage. - The JSON file has two groups, `model` and `search`. The `model` section contains information about the model and the parameters in the `search` section can be modified as desired. - The tokenization files are needed for the tokenizers in the ORT GenAI library. - The full list of additional options can be viewed in the usage section of the README. - By reducing the number of hidden layers, mini models can be created with the model builder tool for testing purposes (e.g. unit testing, CIs). - [This PR](microsoft/Olive#940) is integrating the model builder tool into Olive and wants to import the `create_model` method directly instead of running the script.
devang-ml
reviewed
Feb 27, 2024
shaahji
force-pushed
the
shaahji/genai
branch
from
February 28, 2024 07:22
3065fb5
to
b2ca9ec
Compare
c093dd9 |
trajepl
reviewed
Feb 28, 2024
guotuofeng
reviewed
Feb 28, 2024
trajepl
reviewed
Feb 28, 2024
trajepl
reviewed
Feb 28, 2024
shaahji
force-pushed
the
shaahji/genai
branch
3 times, most recently
from
February 28, 2024 20:03
8b4841b
to
47c513d
Compare
jambayk
reviewed
Feb 29, 2024
jambayk
reviewed
Feb 29, 2024
shaahji
force-pushed
the
shaahji/genai
branch
from
February 29, 2024 09:44
47c513d
to
1e3d20c
Compare
jambayk
reviewed
Feb 29, 2024
jambayk
reviewed
Feb 29, 2024
jambayk
reviewed
Feb 29, 2024
shaahji
force-pushed
the
shaahji/genai
branch
from
February 29, 2024 21:22
1e3d20c
to
5957cf0
Compare
trajepl
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Pass to export a PyTorch model using GenAI exporter
Checklist before requesting a review
lintrunner -a
(Optional) Issue link