[Fix] Resolves operation ids for $count and overloaded functions paths
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps avoid duplicate operation ids in overloaded functions
irvinesunday
requested review from
xuzhg,
darrelmiller,
peombwa,
zengin,
baywet,
millicentachieng and
andrueastman
as code owners
peombwa
reviewed
May 22, 2023
Co-authored-by: Peter Ombwa <peter.ombwa@microsoft.com>
|
SonarCloud Quality Gate failed. |
andrueastman
approved these changes
May 24, 2023
baywet
reviewed
Jun 7, 2023
| @@ -309,24 +310,24 @@ internal static string GenerateODataTypeCastPathOperationIdPrefix(ODataPath path | |||
| string operationId = null; | |||
| if (secondLastSegment is ODataComplexPropertySegment complexSegment) | |||
| { | |||
| string listOrGet = complexSegment.Property.Type.IsCollection() ? "List" : "Get"; | |||
| string listOrGet = includeListOrGetPrefix ? (complexSegment.Property.Type.IsCollection() ? "List" : "Get") : null; | |||
There was a problem hiding this comment.
Less work when we enable NRT this way
Suggested change
| string listOrGet = includeListOrGetPrefix ? (complexSegment.Property.Type.IsCollection() ? "List" : "Get") : null; | |
| string listOrGet = includeListOrGetPrefix ? (complexSegment.Property.Type.IsCollection() ? "List" : "Get") : string.Empty; |
baywet
reviewed
Jun 7, 2023
| ? entitySet.Name + "." + entitySet.EntityType().Name + ".List" + Utils.UpperFirstChar(entitySet.EntityType().Name) | ||
| : singleton.Name + "." + singleton.EntityType().Name + ".Get" + Utils.UpperFirstChar(singleton.EntityType().Name); | ||
| ? entitySet.Name + "." + entitySet.EntityType().Name + $".{(includeListOrGetPrefix ? "List" : null)}" + Utils.UpperFirstChar(entitySet.EntityType().Name) | ||
| : singleton.Name + "." + singleton.EntityType().Name + $".{(includeListOrGetPrefix ? "Get" : null)}" + Utils.UpperFirstChar(singleton.EntityType().Name); |
There was a problem hiding this comment.
Singleton can technically be null here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383, #382
This PR: