Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alternate keys in the generation of operation ids of operations and navigation property alternate paths #489

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Use alternate keys in the generation of operation ids of operations and navigation property alternate paths #489

merged 5 commits into from
Feb 5, 2024

Conversation

irvinesunday
Copy link
Collaborator

@irvinesunday irvinesunday commented Feb 5, 2024 •
edited
Loading

Fixes #488

This PR:

  • Uses alternate key segment identifiers in the generation of operation ids of operations and navigation property alternate paths.
  • Adds tests to validate that alternate key identifiers are used in the generation of operation ids.
  • Updates the integration test file.
  • Updates release notes.

@irvinesunday irvinesunday self-assigned this Feb 5, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
81.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@irvinesunday irvinesunday merged commit 93c5300 into master Feb 5, 2024
10 of 12 checks passed
@irvinesunday irvinesunday deleted the is/alternate-key-opIds branch February 5, 2024 14:37
@irvinesunday irvinesunday mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@xuzhg xuzhg Awaiting requested review from xuzhg xuzhg is a code owner

@darrelmiller darrelmiller Awaiting requested review from darrelmiller darrelmiller is a code owner

@peombwa peombwa Awaiting requested review from peombwa

@zengin zengin Awaiting requested review from zengin zengin is a code owner

@millicentachieng millicentachieng Awaiting requested review from millicentachieng millicentachieng is a code owner

@andrueastman andrueastman Awaiting requested review from andrueastman andrueastman is a code owner

@timayabi2020 timayabi2020 Awaiting requested review from timayabi2020

Assignees

@irvinesunday irvinesunday

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate operation Ids for paths with alternate keys
2 participants
@irvinesunday @baywet