Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix casing of OpenAPI type "String" for RefPatchOperationHandler and RefPostOperationHandler #78

Merged
merged 3 commits into from Dec 1, 2020
Merged

Fix casing of OpenAPI type "String" for RefPatchOperationHandler and RefPostOperationHandler #78

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca28c4c
Fix casing from "String" to "string"
edevoogd Jun 2, 2020
20309c4
Fix tests resources
edevoogd Jun 3, 2020
d1b018b
Merge branch 'master' into edevoogd/lowercase-type-String
xuzhg Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Microsoft.OpenApi.OData.Reader/Operation/RefPatchOperationHandler.cs
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ protected override void SetRequestBody(OpenApiOperation operation)
{
OpenApiSchema schema = new OpenApiSchema
{
Type = "String"
Type = "string"
};

operation.RequestBody = new OpenApiRequestBody
Expand Down
4 changes: 2 additions & 2 deletions src/Microsoft.OpenApi.OData.Reader/Operation/RefPostOperationHandler.cs
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ protected override void SetRequestBody(OpenApiOperation operation)
{
OpenApiSchema schema = new OpenApiSchema
{
Type = "String"
Type = "string"
};

operation.RequestBody = new OpenApiRequestBody
Expand All @@ -66,7 +66,7 @@ protected override void SetResponses(OpenApiOperation operation)
{
OpenApiSchema schema = new OpenApiSchema
{
Type = "String" // What to return?
Type = "string" // What to return?
};

operation.Responses = new OpenApiResponses
Expand Down
14 changes: 7 additions & 7 deletions test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.V2.json
View file
Open in desktop
Expand Up @@ -998,15 +998,15 @@
"description": "New navigation property ref value",
"required": true,
"schema": {
"type": "String"
"type": "string"
}
}
],
"responses": {
"201": {
"description": "Created navigation property link.",
"schema": {
"type": "String"
"type": "string"
}
},
"default": {
Expand Down Expand Up @@ -1707,15 +1707,15 @@
"description": "New navigation property ref value",
"required": true,
"schema": {
"type": "String"
"type": "string"
}
}
],
"responses": {
"201": {
"description": "Created navigation property link.",
"schema": {
"type": "String"
"type": "string"
}
},
"default": {
Expand Down Expand Up @@ -2272,7 +2272,7 @@
"description": "New navigation property ref values",
"required": true,
"schema": {
"type": "String"
"type": "string"
}
}
],
Expand Down Expand Up @@ -3031,15 +3031,15 @@
"description": "New navigation property ref value",
"required": true,
"schema": {
"type": "String"
"type": "string"
}
}
],
"responses": {
"201": {
"description": "Created navigation property link.",
"schema": {
"type": "String"
"type": "string"
}
},
"default": {
Expand Down
14 changes: 7 additions & 7 deletions test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.V2.yaml
View file
Open in desktop
Expand Up @@ -720,12 +720,12 @@ paths:
description: New navigation property ref value
required: true
schema:
type: String
type: string
responses:
'201':
description: Created navigation property link.
schema:
type: String
type: string
default:
$ref: '#/responses/error'
x-ms-docs-operation-type: operation
Expand Down Expand Up @@ -1231,12 +1231,12 @@ paths:
description: New navigation property ref value
required: true
schema:
type: String
type: string
responses:
'201':
description: Created navigation property link.
schema:
type: String
type: string
default:
$ref: '#/responses/error'
x-ms-docs-operation-type: operation
Expand Down Expand Up @@ -1654,7 +1654,7 @@ paths:
description: New navigation property ref values
required: true
schema:
type: String
type: string
responses:
'204':
description: Success
Expand Down Expand Up @@ -2207,12 +2207,12 @@ paths:
description: New navigation property ref value
required: true
schema:
type: String
type: string
responses:
'201':
description: Created navigation property link.
schema:
type: String
type: string
default:
$ref: '#/responses/error'
x-ms-docs-operation-type: operation
Expand Down
14 changes: 7 additions & 7 deletions test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.json
View file
Open in desktop
Expand Up @@ -1135,7 +1135,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
},
Expand All @@ -1147,7 +1147,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
}
Expand Down Expand Up @@ -1957,7 +1957,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
},
Expand All @@ -1969,7 +1969,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
}
Expand Down Expand Up @@ -2597,7 +2597,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
},
Expand Down Expand Up @@ -3466,7 +3466,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
},
Expand All @@ -3478,7 +3478,7 @@
"content": {
"application/json": {
"schema": {
"type": "String"
"type": "string"
}
}
}
Expand Down
14 changes: 7 additions & 7 deletions test/Microsoft.OpenAPI.OData.Reader.Tests/Resources/Multiple.Schema.OpenApi.yaml
View file
Open in desktop
Expand Up @@ -807,15 +807,15 @@ paths:
content:
application/json:
schema:
type: String
type: string
required: true
responses:
'201':
description: Created navigation property link.
content:
application/json:
schema:
type: String
type: string
default:
$ref: '#/components/responses/error'
x-ms-docs-operation-type: operation
Expand Down Expand Up @@ -1390,15 +1390,15 @@ paths:
content:
application/json:
schema:
type: String
type: string
required: true
responses:
'201':
description: Created navigation property link.
content:
application/json:
schema:
type: String
type: string
default:
$ref: '#/components/responses/error'
x-ms-docs-operation-type: operation
Expand Down Expand Up @@ -1859,7 +1859,7 @@ paths:
content:
application/json:
schema:
type: String
type: string
required: true
responses:
'204':
Expand Down Expand Up @@ -2482,15 +2482,15 @@ paths:
content:
application/json:
schema:
type: String
type: string
required: true
responses:
'201':
description: Created navigation property link.
content:
application/json:
schema:
type: String
type: string
default:
$ref: '#/components/responses/error'
x-ms-docs-operation-type: operation
Expand Down