-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI.NET 1.2.0 is not backwards compatible with 1.1.x #487
Comments
This just bit me
|
Added a PR: #489 Would be nice to merge it, bump your version and unlist 1.2.0 |
@darrelmiller any chance for your input on this one please? |
Ugh. Apparently optional parameters have source backward compatibility but not binary backward compatibility. |
Yep :) Compiler magic... |
Prevent breaking change on optional parameter #487
With 1.2.1, the previous
|
@hasancemcerit PR ongoing to fix it: #492 |
It's fixed. 1.2.2 has no breaking changes, and the others got delisted. @darrelmiller This can probably be closed now :) |
@CumpsD Thank you for your help with this. |
Version 1.2.0 is not backwards compatible with 1.1.x. For example, the constructor of OpenApiString has changed from:
to
If another project references the old version, it cannot find the constructor since its signature has changed. It would have been better to add a new constructor or increase the major version number of the package (if you adhere to semantic versioning). At the very least, breaking api changes should be documented in the release notes.
The text was updated successfully, but these errors were encountered: