Fix line break issues in unit tests when built in a different environment #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed and actual serialized strings - change `expect` to `expected` in all places in unit tests
|
@PerthCharern, |
xuzhg
approved these changes
Nov 7, 2017
| Assert.Equal("name: Default Name", actual); | ||
| actual = actual.MakeLineBreaksEnvironmentNeutral(); | ||
| expected = expected.MakeLineBreaksEnvironmentNeutral(); | ||
| Assert.Equal(expected, actual); |
There was a problem hiding this comment.
I am wondering "You are stilling using XUnit.Assert? "
I think it's better to only use one framework. So, if the XUnit.Assert can't meet our requirement, we can extend it. Thoughts?
There was a problem hiding this comment.
Well, in this PR, I don't want to change those existing Asserts yet. My plan is to move everything to FluentAssertions, unless you object. For future unit tests, are you comfortable with writing them using FluentAssertions?
There was a problem hiding this comment.
Either is ok for me. But, only one. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always call
MakeLineBreaksEnvironmentNeutralbefore comparing actual and expected strings.Change
expecttoexpectedin all places in unit tests