Add sqlsrv to PHP FPM 8.1 runtime image #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cormacpayne
changed the title
daniv-msft
reviewed
Oct 21, 2022
Yes, I can see that the PR who made that changes updated the runtime images for PHP, but not for PHP-FPM. Thanks for catching. |
daniv-msft
reviewed
Oct 21, 2022
pauld-msft
reviewed
Oct 21, 2022
daniv-msft
reviewed
Oct 21, 2022
daniv-msft
previously approved these changes
Oct 21, 2022
pauld-msft
reviewed
Oct 24, 2022
daniv-msft
approved these changes
Oct 24, 2022
harryli0108
added a commit
that referenced
this pull request
Oct 25, 2022
* Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com>
harryli0108
added a commit
that referenced
this pull request
Oct 26, 2022
* Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> * Moving an end pf line character in the .NET 7 gRPC case (#1629) Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com>
harryli0108
added a commit
that referenced
this pull request
Oct 26, 2022
* Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> * Moving an end pf line character in the .NET 7 gRPC case (#1629) * Fixed node base image script (#1631) * renamed bullseye files to buster and fixed typo * removed extra debian flavor args * fixed runtime tests to use correct os type Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com>
harryli0108
added a commit
that referenced
this pull request
Oct 28, 2022
* updated node version in code * Added new version to versionsToBuild * removed new version support for stretch * Updating nodeVersionUpdate Branch (#1630) * Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> * Updating branch to include the final stretch version config (#1632) * Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> * Moving an end pf line character in the .NET 7 gRPC case (#1629) Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com> * Update the branch to fix runtime image (#1633) * Add sqlsrv to PHP FPM 8.1 runtime image (#1623) * Add sqlsrv to PHP 8.1 runtime image * Update base image tag for PHP FPM runtime images * Use updated base image tag for PHP FPM runtime images * Update service connection used to authorize calls to oryx-automation resource group (#1628) * Lock in final stretch versions for node 14 and node 16 (#1627) * lock in final stretch versions for node 14 and node 16 * Update service connection used to authorize calls to oryx-automation resource group Co-authored-by: Cormac McCarthy <corm@microsoft.com> * Moving an end pf line character in the .NET 7 gRPC case (#1629) * Fixed node base image script (#1631) * renamed bullseye files to buster and fixed typo * removed extra debian flavor args * fixed runtime tests to use correct os type Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com> * add support for debian flavor to build-script (#1634) Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com> * updated so that ONLY build-script command is affected by the debian flavor change, and respects environment variable configuration * updated new baseimage tag for node * fixes for the runtime dynamic installation Co-authored-by: Cormac McCarthy <corm@microsoft.com> Co-authored-by: Paul Dorsch <107068277+pauld-msft@users.noreply.github.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com> Co-authored-by: Paul Dorsch <pauldorsch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate the PHP FPM bullseye runtime images with the latest changes from the template file, included updated logic that will include
sqlsrvwith the PHP FPM 8.1 runtime image. Also include tests to ensure thatsqlsrvis available across all PHP FPM runtime versions.- [ ] Proper license headers are included in each file.