Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax highlighting includes keywords that are included in comments #10

Closed
BernieWhite opened this issue Apr 19, 2019 · 0 comments · Fixed by #13
Closed

Syntax highlighting includes keywords that are included in comments #10

BernieWhite opened this issue Apr 19, 2019 · 0 comments · Fixed by #13
Assignees
@BernieWhite
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@BernieWhite
Copy link
Member

Description of the issue

A comment within a Rule block may include words such as ensure or within. Currently these are highlighted as keywords.

Keywords used outside of a Rule block are not highlighted and treated as comments, which is correct.

To Reproduce

Steps to reproduce the issue:

Rule 'example' {
    # Check that within the block there is comments
}

In the example above, within is incorrectly highlighted as a keyword.

Expected behaviour

Keywords within comments should not be highlighted as a keyword.

Extension version:

  • Version: 0.1.0
@BernieWhite BernieWhite added the bug Something isn't working label Apr 19, 2019
@BernieWhite BernieWhite added this to the v0.2.0 milestone Apr 19, 2019
@BernieWhite BernieWhite self-assigned this Apr 19, 2019
BernieWhite added a commit that referenced this issue Apr 30, 2019
@BernieWhite
Fix syntax highlighting #10
b4e0300
@BernieWhite BernieWhite mentioned this issue Apr 30, 2019
Merged
6 tasks
BernieWhite added a commit that referenced this issue Apr 30, 2019
@BernieWhite
Fix syntax highlighting and update options schema #10 #12 (#13)
a49f4ea 
* Fix syntax highlighting #10
* Update PSRule options schema to v0.5.0 #12
* Bump dependency versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Fix syntax highlighting and update options schema #10 #12 microsoft/PSRule-vscode
1 participant
@BernieWhite