Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI badge not displaying in VSCode extension tab #8

Closed
BernieWhite opened this issue Apr 19, 2019 · 0 comments · Fixed by #11
Closed

CI badge not displaying in VSCode extension tab #8

BernieWhite opened this issue Apr 19, 2019 · 0 comments · Fixed by #11
Assignees
@BernieWhite
Labels
bug Something isn't working
Milestone
v0.2.0

Comments

@BernieWhite
Copy link
Member

Description of the issue

CI badge from *.visualstudio.com is not in safe exclusion list. Badge should be changed to originate from dev.azure.com domain instead.

To Reproduce

Steps to reproduce the issue:

  • Open PSRule extension details from VSCode. Where image should be, ci-bage placeholder is displayed instead of badge.

Expected behaviour

Badge should be displayed.

Extension version:

  • Version: 0.1.0
@BernieWhite BernieWhite added this to the v0.2.0 milestone Apr 19, 2019
@BernieWhite BernieWhite added the bug Something isn't working label Apr 19, 2019
@BernieWhite BernieWhite self-assigned this Apr 19, 2019
@BernieWhite BernieWhite changed the title CI badge doesn't display in VSCode extension tab CI badge not displaying in VSCode extension tab Apr 19, 2019
BernieWhite added a commit that referenced this issue Apr 19, 2019
@BernieWhite
Updated CI badge to use dev.azure.com #8
a6104bb
@BernieWhite BernieWhite mentioned this issue Apr 19, 2019
Merged
4 tasks
BernieWhite added a commit that referenced this issue Apr 19, 2019
@BernieWhite
Updated PSRule options schema and CI badge #9 #8 (#11)
758d64b 
* Updated PSRule options schema to v0.4.0 #9
* Updated CI badge to use dev.azure.com #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Updated PSRule options schema and CI badge #9 #8 microsoft/PSRule-vscode
1 participant
@BernieWhite