Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read JSON failed for JSON with comments #1051

Closed
BernieWhite opened this issue Apr 15, 2022 · 0 comments · Fixed by #1055
Closed

Read JSON failed for JSON with comments #1051

BernieWhite opened this issue Apr 15, 2022 · 0 comments · Fixed by #1055
Assignees
Labels
bug Something isn't working feature: input Issues that affect input
Milestone

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Apr 15, 2022

Description of the issue

JSON files fail to be read the file starts with a comment on the first line instead of an object or array.

To Reproduce

Steps to reproduce the issue:

// For format details, see https://aka.ms/devcontainer.json.
{
}

Expected behaviour

Should handle comments in JSON.

Error output

Read JSON failed.

Module in use and version:

  • Module: PSRule
  • Version: 2.0.0

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      7.2.2
PSEdition                      Core
GitCommitId                    7.2.2
OS                             Microsoft Windows 10.0.22000
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@BernieWhite BernieWhite added bug Something isn't working feature: input Issues that affect input labels Apr 15, 2022
@BernieWhite BernieWhite self-assigned this Apr 16, 2022
@BernieWhite BernieWhite added this to the v2.0.1 milestone Apr 16, 2022
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Apr 16, 2022
BernieWhite added a commit that referenced this issue Apr 16, 2022
* Fix JSON parsing and null ref #1051 #1054 #1052

* Fix updated line number in tests
@BernieWhite BernieWhite mentioned this issue Apr 16, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature: input Issues that affect input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant