Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename and improvement of logging options #1456

Closed
5 tasks done
BernieWhite opened this issue Feb 26, 2023 · 0 comments · Fixed by #1513
Closed
5 tasks done

Rename and improvement of logging options #1456

BernieWhite opened this issue Feb 26, 2023 · 0 comments · Fixed by #1513
Assignees
@BernieWhite
Labels
enhancement New feature or request feature: options Issues that affect options
Milestone
v2.9.0

Comments

@BernieWhite
Copy link
Member

BernieWhite commented Feb 26, 2023 •
edited
Loading

PSRule includes a number of execution options that configure logging of certain events. Currently these only support turning a warning on or off.

In certain circumstances it may be desired to generate an error instead. Since they all include warning in their name, we should rename them and use the ExecutionActionPreference enumeration to allow setting Ignore, Error, Warn, or Debug for any of these options.

  • Execution.AliasReferenceWarning to be replaced by Execution.AliasReference.
  • Execution.InconclusiveWarning to be replaced by Execution.RuleInconclusive.
  • Execution.InvariantCultureWarning to be replaced by Execution.InvariantCulture.
  • Execution.NotProcessedWarning to be replaced by Execution.UnprocessedObject.
  • Execution.SuppressedRuleWarning to be replaced by Execution.RuleSuppressed.

The old variants should be removed with PSRule v3. Which is a breaking change.
@BernieWhite BernieWhite added enhancement New feature or request feature: options Issues that affect options labels Feb 26, 2023
@BernieWhite BernieWhite mentioned this issue Feb 26, 2023
Closed
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Feb 26, 2023
@BernieWhite
Logging output improvements microsoft#1456 microsoft#1432
16735d1
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Feb 26, 2023
@BernieWhite
Logging output improvements microsoft#1456 microsoft#1432
4c4206f
@BernieWhite BernieWhite mentioned this issue Feb 26, 2023
Merged
7 tasks
BernieWhite added a commit that referenced this issue Mar 2, 2023
@BernieWhite
Logging output improvements #1456 #1432 (#1458)
7ee8977 
* Logging output improvements #1456 #1432

* Fix URLs
@BernieWhite BernieWhite mentioned this issue Mar 2, 2023
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Mar 27, 2023
Merged
4 tasks
@BernieWhite BernieWhite self-assigned this Apr 23, 2023
@BernieWhite BernieWhite added this to the v2.9.0 milestone Apr 23, 2023
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Apr 23, 2023
@BernieWhite
Rename and improvement of logging options microsoft#1456
43819c1
@BernieWhite BernieWhite mentioned this issue Apr 23, 2023
Merged
7 tasks
BernieWhite added a commit that referenced this issue Apr 23, 2023
@BernieWhite
Rename and improvement of logging options #1456 (#1513)
657c054
@BernieWhite BernieWhite mentioned this issue Apr 23, 2023
Merged
4 tasks
@BernieWhite BernieWhite mentioned this issue Jun 8, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BernieWhite BernieWhite

Labels
enhancement New feature or request feature: options Issues that affect options
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging a pull request may close this issue.

Rename and improvement of logging options #1456 BernieWhite/PSRule
1 participant
@BernieWhite