Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version constraint handling for pre-releases with -0 #712

Closed
BernieWhite opened this issue May 14, 2021 · 0 comments · Fixed by #713
Closed

Version constraint handling for pre-releases with -0 #712

BernieWhite opened this issue May 14, 2021 · 0 comments · Fixed by #713
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Member

BernieWhite commented May 14, 2021

Description of the issue

Handling of version constraints with the -0 syntax doesn't evaluate correctly.

e.g.

# Set PSRule version requirements
requires:
  PSRule: '>=1.4.0-0'

Expected behaviour

The version constraint >=1.4.0-0 should allow:

  • Any stable versions greater or equal to 1.4.0.
  • Any pre-release versions of 1.4.0, since -0 is not a valid semver it can only but used by a constraint. Thus all pre-releases of 1.4.0 would be greater.

Error output

The module version '1.4.0-B2105004' for 'PSRule' does not match the required version '>=1.4.0-0'.

Module in use and version:

  • Module: PSRule
  • Version: 1.4.0-B2105004

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

Additional information

npm semver
semantic versioning npm
semver

@BernieWhite BernieWhite added the bug Something isn't working label May 14, 2021
@BernieWhite BernieWhite added this to the v1.4.0 milestone May 14, 2021
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue May 15, 2021
@BernieWhite BernieWhite linked a pull request May 15, 2021 that will close this issue
7 tasks
@BernieWhite BernieWhite self-assigned this May 16, 2021
@BernieWhite BernieWhite mentioned this issue Jun 3, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant