Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options schema should allow spacing after @pre for requires #743

Closed
BernieWhite opened this issue Jul 6, 2021 · 0 comments · Fixed by #744
Closed

Options schema should allow spacing after @pre for requires #743

BernieWhite opened this issue Jul 6, 2021 · 0 comments · Fixed by #744
Assignees
Labels
bug Something isn't working
Milestone

Comments

@BernieWhite
Copy link
Member

Description of the issue

The PSRule options schema currently doesn't allow the following however should:

requires:
  PSRule: '@pre >=1.4.0'

This doesn't affect actual execution, but schema validation in VSCode incorrectly shows an error.

Expected behaviour

Allow a space directly after @pre

Module in use and version:

  • Module: PSRule
  • Version: 1.5.0-B2106006

Captured output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      7.1.3
PSEdition                      Core
GitCommitId                    7.1.3
OS                             Microsoft Windows 10.0.19043
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0
@BernieWhite BernieWhite added the bug Something isn't working label Jul 6, 2021
@BernieWhite BernieWhite added this to the v1.5.0 milestone Jul 6, 2021
@BernieWhite BernieWhite self-assigned this Jul 6, 2021
BernieWhite added a commit to BernieWhite/PSRule that referenced this issue Jul 6, 2021
BernieWhite added a commit that referenced this issue Jul 7, 2021
@BernieWhite BernieWhite mentioned this issue Jul 18, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant